Use AddStringOrBlob to create to duckdb string from blob value #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To construct output string use`AddStringOrBlob` which doesn't require that input is valid UTF8.
|
Looks reasonable - can we add a small test? |
Issue that this PR is fixing will be triggered if regression suite is run on debug build. |
Y--
approved these changes
Jan 8, 2025
ritwizsinha
pushed a commit
to ritwizsinha/pg_duckdb
that referenced
this pull request
Jan 11, 2025
…b#521) To construct output string use`AddStringOrBlob` which doesn't require that input is valid UTF8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To construct output string use
AddStringOrBlobwhich doesn't require that input is valid UTF8.