Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quack IndexScan #45

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Quack IndexScan #45

merged 2 commits into from
Jul 3, 2024

Conversation

mkaruza
Copy link
Collaborator

@mkaruza mkaruza commented Jun 17, 2024

  • Support IndexScan. Based on best path we will execute IndexScan or fallback to normal seq scan.

@mkaruza mkaruza requested a review from Tishj June 17, 2024 07:07
Base automatically changed from replace_views to main June 18, 2024 11:46
@wuputah
Copy link
Collaborator

wuputah commented Jun 19, 2024 •
edited
Loading

closes #22 - at least to my satisfaction. we can add a separate issue for other index types (i.e. BRIN).

@wuputah
Copy link
Collaborator

wuputah commented Jun 25, 2024

can you explain the impact of the lock here?

@mkaruza
Copy link
Collaborator Author

mkaruza commented Jun 27, 2024

can you explain the impact of the lock here?

Running query like (SELECT count(*) FROM t) UNION (SELECT count(*) FROM m) will prepare two replacement scans which will run. We are protecting with lock - but this only applies for single replacement scan. This lock doesn't protect between multiple replacement scans (which is needed because PG functions are not thread safe).

Tishj
Tishj approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@Tishj Tishj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mkaruza added 2 commits July 2, 2024 09:26
@mkaruza
Quack IndexScan
8ba669c 
* Support IndexScan. Based on best path we will execute IndexScan or
  fallback to normal seq scan.
@mkaruza
Global process lock
2def419 
* When there are multiple replacement scan running in same process we
  still need to protect calls to PG functions that are not thread safe.
@wuputah wuputah merged commit 5f80d0c into main Jul 3, 2024
2 checks passed
@wuputah wuputah deleted the index-scan branch July 3, 2024 16:37
@wuputah wuputah mentioned this pull request Jul 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tishj Tishj Tishj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkaruza @wuputah @Tishj