-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Point to the most recent version of duckdb submodule #7
Conversation
@Tmonster please take a look. I tried to compile and to run tests - everything worked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, would like to know first is @samansmink has any concerns (I've never done this before and would like to not break CI or the extension ecosystem)
I think its fine, basically and extension can either track latest stable, or like sqlsmith is doing now, Note that some extensions do actually use the submodule version in CI, for example: https://github.com/duckdb/duckdb_iceberg/blob/main/.github/workflows/Rest.yml. |
@hmeriann can you check that the extension ci tools are also set to the latest duckdb version? @samansmink all other references to a duckdb stable version should reference v1.0.0 so I think this will be fine |
@Tmonster sure, I'll check it |
This PR pushes a new submodule pointer in the
sqlsmith_smith
repository as described here