avoid CatalogType::TABLE_MACRO_ENTRY which can cause SIGABRT

[hmeriann]

StatementGenerator::GetDatabaseState() recognises the CatalogType::TABLE_MACRO_ENTRY as a table_functions according to the CatalogSet &DuckSchemaEntry::GetCatalogSet(CatalogType type).

During a discussion with @Tmonster it was decided to avoid CatalogType::TABLE_MACRO_ENTRY in the Statement Generator.

[Tmonster]

random_val?

[Tmonster]

can the logic of the while loop change a bit?

1. random_val +=1 % generator_context->table_functions.size();
2. if (random_val == original_val) -> Error
3. table_function_ref = &generator_context->table_functions[random_val]

This way we can prevent an infinite loop

[Tmonster]

RandomValue(original_val) is still here, you can just have

table_function_ref = &generator_context->table_functions[random_val]; since random_val was increased by 1

[Tmonster]

sorry, but realizing this is still wrong.

original_val is set to the size of the generator_context->table_functions vector.
original_val should be the first random value (i.e the RandomValue() returned on line 521.

Then random_val can be increased in the while loop (with the modulo) until it is equal to original_val

[Tmonster]

Basically it should look like

auto num_table_functions = generator_context->table_functions.size();
auto random_val = RandomValue(original_val);
auto original_val = random_val;
auto table_function_ref = &generator_context->table_functions[random_val];
while (table_function_ref->get().type == CatalogType::TABLE_MACRO_ENTRY) {
    random_val += 1; // I also think the + and modulo needs to be split up, 
                     // otherwise you get random_val = random_val + (1 % num_table_functions)
    random_val = random_val % num_table_functions;
    if (random_val == original_val) {
        ....
    }
}

[hmeriann]

Sorry, I didn't get all these details earlier. Fixed

[Tmonster]

great thanks!