feat: register_function as decorator version of create_function#261
Closed
tylerriccio33 wants to merge 6 commits intoduckdb:v1.5-variegatafrom
Closed
feat: register_function as decorator version of create_function#261tylerriccio33 wants to merge 6 commits intoduckdb:v1.5-variegatafrom
register_function as decorator version of create_function#261tylerriccio33 wants to merge 6 commits intoduckdb:v1.5-variegatafrom
Conversation
Collaborator
|
Hey @tylerriccio33, thanks for the PR! I get the allure of a decorator, but an instance method as a decorator is a little awkward... Plus, it's limiting: you may want to register the function on multiple connections. The monkey patching ( You're right that this would need more tests as well, but tbh I don't think we should be doing this at all, at least not in the current form. It's easy enough for users to provide their own wrapper: BTW: we're likely to rework UDFs this year. Decorators are on the list as well! |
Author
|
Alrighty, makes sense! Interested in the UDF rework |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR seeks to add a new method for decorating a python function, which registers it against an existing connection.
We use duckdb at my job a lot, and one thing we'd love to do is use a decorator on top of a function instead of calling the create_function method. The decorator, at times, feels more pythonic.
This PR implements this feature as syntactic sugar in python only. There is no cpp implementation which seems to be abnormal for this client. Please let me know if this is acceptable, and if not I'll change it!
Second, I'm seeking the maintainer's opinion on a testing regime... I have dedicated tests of course, but I'd love to incorporate some existing tests around
create_function. I parametrized one intests/fast/udf/test_scalar_arrow.pybut that's all. Let me know if you want more and I can!