try adding double quotes to zip url

duckdb · Jun 30, 2024 · 868a578 · 868a578
1 parent fb077ee
commit 868a578
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/alt/bindings/binding.gyp b/alt/bindings/binding.gyp
@@ -6,17 +6,17 @@
       'conditions': [
         ['OS=="linux"', {
           'variables': {
-            'zip_url': 'https://github.com/duckdb/duckdb/releases/download/v1.0.0/libduckdb-linux-amd64.zip',
+            'zip_url': '"https://github.com/duckdb/duckdb/releases/download/v1.0.0/libduckdb-linux-amd64.zip"',
           },
         }],
         ['OS=="mac"', {
           'variables': {
-            'zip_url': 'https://github.com/duckdb/duckdb/releases/download/v1.0.0/libduckdb-osx-universal.zip',
+            'zip_url': '"https://github.com/duckdb/duckdb/releases/download/v1.0.0/libduckdb-osx-universal.zip"',
           },
         }],
         ['OS=="win"', {
           'variables': {
-            'zip_url': 'https://github.com/duckdb/duckdb/releases/download/v1.0.0/libduckdb-windows-amd64.zip',
+            'zip_url': '"https://github.com/duckdb/duckdb/releases/download/v1.0.0/libduckdb-windows-amd64.zip"',
           },
         }],
       ],

diff --git a/alt/bindings/scripts/fetch_libduckdb.py b/alt/bindings/scripts/fetch_libduckdb.py
@@ -31,7 +31,7 @@
 urllib.request.urlretrieve(libduckdb_zip_url, libduckdb_zip_path)
 
 zip = zipfile.ZipFile(libduckdb_zip_path)
-print("extracting: " + zip.namelist())
+print("extracting: " + ", ".join(zip.namelist()))
 zip.extractall(output_dir)
 
 # for file_name in libduckdb_file_names: