Skip to content

Commit

Permalink
fix python, disable os x again (it works)
Browse files Browse the repository at this point in the history
  • Loading branch information
jraymakers committed Jun 19, 2024
1 parent 9db2985 commit 0321ffe
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/workflows/NodeJS.yml
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ jobs:
# run: ./scripts/node_build.sh ${{ matrix.node }}

osx-nodejs:
if: false # temporarily disabled while testing
# if: startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main' || github.repository != 'duckdb/duckdb-node'
name: node.js OSX
runs-on: macos-latest
Expand Down
4 changes: 2 additions & 2 deletions generate-wrapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -218,13 +218,13 @@ def get_release_zip_url():
elif machine == "amd64":
return "https://github.com/duckdb/duckdb/releases/download/v1.0.0/libduckdb-linux-amd64.zip"
else:
raise "Unsupported machine: " + machine
raise Exception("Unsupported machine: " + machine)
elif system == "Darwin":
return "https://github.com/duckdb/duckdb/releases/download/v1.0.0/libduckdb-osx-universal.zip"
elif system == "Windows":
return "https://github.com/duckdb/duckdb/releases/download/v1.0.0/libduckdb-windows-amd64.zip"
else:
raise "Unsupported system: " + system
raise Exception("Unsupported system: " + system)

if __name__ == "__main__":

Expand Down

0 comments on commit 0321ffe

Please sign in to comment.