Skip to content

Optimize Map2Kvs functions by pre-allocating memory #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yedf2 merged 2 commits into from
Nov 24, 2024
Merged

Optimize Map2Kvs functions by pre-allocating memory #522

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f73b559
Optimize Map2Kvs functions by pre-allocating memory
me-cs Sep 23, 2024
d34bbd1
update:use len(m) * 2 because it is more readable.
me-cs Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions client/dtmgrpc/dtmgimp/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@
package dtmgimp

import (
context "context"
"context"

"github.com/dtm-labs/dtm/client/dtmcli/dtmimp"
"github.com/dtm-labs/dtm/client/dtmgrpc/dtmgpb"
"github.com/dtm-labs/logger"
"google.golang.org/grpc/metadata"
"google.golang.org/protobuf/proto"
emptypb "google.golang.org/protobuf/types/known/emptypb"
"google.golang.org/protobuf/types/known/emptypb"
)

// MustProtoMarshal must version of proto.Marshal
Expand Down Expand Up @@ -77,7 +77,7 @@ func TransInfo2Ctx(ctx context.Context, gid, transType, branchID, op, dtm string

// Map2Kvs map to metadata kv
func Map2Kvs(m map[string]string) []string {
kvs := []string{}
kvs := make([]string, 0, len(m)<<1)
for k, v := range m {
kvs = append(kvs, k, v)
}
Expand Down