Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was interested in this package and when trying to install via
pipx
noticed that none of the dependencies were installed due to #17 (fixed by #30).Also the requirements weren't pinned and since this is a self-contained application, not a library meant to be imported, pinning all dependencies seemed like a good idea.
To do that I converted the project from
setup.py
to Poetry with apyproject.toml
file, committed thepoetry.lock
file so that the pinned packages are used, and changed the way the command line argument is exposed so thattermpdf
is added tobin
during installation of the package.Updated the readme to cover the new installation instructions.
Not sure if this would be accepted as it is a large change to how the project is packaged, so feel free to reject if you prefer
setup.py
.