-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the yaml cache fully thread-safe #440
Conversation
specs dont seem to be related to this change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid spec failures are indeed caused by the fix, seems like cache isn't cleared properly between spec runs now.
Got it. WIll look at this today. |
I have main failing locally too, investigating
|
main is green, merging |
@mensfeld You missed the |
@granthusbands I did not miss it. I explicitly do not do it here to make the change small. I pointed out in the article that I wanted to keep the scope small because I do not know how given libs operate.
Not exactly the same. In most cases, I fixed the internal |
is prone to a race condition, thus the cache won't be fully thread safe if definitions are parsed in multiple threads.
This PR fixes that.
Ref: ruby-concurrency/concurrent-ruby#970