Add Ability to Disable Default Pattern Data Rules + Add Extra Pattern Data Rules #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for for any of the default set of Pattern Lab data rules to be optionally disabled in addition to allowing for extra rules to be added as well. While not that big of a change in of itself (besides checking a couple optional config options) this opens the door wide open for the customization and continued evolution of Pattern Lab well beyond what is currently possible.
cough Installable Components cough
Should address the two main use cases described in #11.
To Disable A Default Pattern Lab Rule
For example, to disable the default Markdown documentation rule, add the following to your config.yml file:
To Add A New Custom Rule
To add a new extra rule (say, to locally add in a super-powered markdown data rule that allows Twig templates to get embedded and compiled in .md files) add the following to your
config.yml
config + create a new_extensions/rules
folder in your PL source folder to house your new Rule files.With a new test rule file (
DocumentationRule.php
) added tosource/_extensions/rules/DocumentationRule.php
Customize Pattern Rule Folder Location
There's also an optional config option to specify the location of your rules folder:
CC @evanmwillhite @aleksip @legostud
Side note: @christophersmith262 sorry, I totally didn't realize you had already created a feature branch for this a while back (allowing for default PL rules to be disabled) until I was tried to push my feature branch for this.
Could you take a peek at what I came up with to see if there's a way to incorporate your single array / loop approach idea with this while still allowing for rules to either be opted out of and/or opted in?