Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escaping to git ref in path not working #243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chamhaw
Copy link

@chamhaw chamhaw commented Feb 8, 2023

It seems an inadvertent mistake for escaping.

@bradrydzewski
Copy link
Member

Great catch. I feel like there may be one more bug fix needed. Once we properly escape the reference it would prevent the subsequent scm.TrimRef call from working properly. I'm not sure if / how this would manifest into a bug, but it would be great to do some more research on this and maybe get some unit tests for the different scenarios. cc @d1wilko @tphoney

@chamhaw
Copy link
Author

chamhaw commented Apr 7, 2023

Can this bug be fixed?
@bradrydzewski @d1wilko @tboerger

@bradrydzewski
Copy link
Member

bradrydzewski commented Apr 7, 2023

@chamhaw this needs to be addressed before we can get this merged

Once we properly escape the reference it would prevent the subsequent scm.TrimRef call from working properly

I think it is a simple order of operations issue. trim before you encode and that probably resolves the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants