Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused variable #438

Open
wants to merge 2 commits into
base: minor_issues
Choose a base branch
from
Open

Remove unused variable #438

wants to merge 2 commits into from

Conversation

bagage
Copy link

@bagage bagage commented Sep 22, 2017

No description provided.

@mmd-osm
Copy link
Contributor

mmd-osm commented Sep 22, 2017

While you're at it: there's another issue here: 4cc57fb#comments

@bagage
Copy link
Author

bagage commented Sep 23, 2017

Readded @mmd-osm.

@mmd-osm
Copy link
Contributor

mmd-osm commented Sep 23, 2017 •
edited
Loading

That's not exactly what I meant, I should read std::string result = "(id:"; like it already was here:

Overpass-API/src/overpass_api/statements/id_query.h

Line 81 in 00e1c01

std::string result = "(id:";

Or even better would be something like:

std::string result = (refs.size() > 1 ? "(id:" : "(");

@bagage
Copy link
Author

bagage commented Sep 23, 2017

@mmd-osm Does it sound better now?

@bagage bagage closed this Sep 23, 2017
@bagage bagage deleted the minor_issues branch September 23, 2017 13:09
@bagage bagage restored the minor_issues branch September 23, 2017 13:09
@bagage bagage reopened this Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bagage @mmd-osm