Skip to content

Conversation

@badrbouslikhin
Copy link
Collaborator

@badrbouslikhin badrbouslikhin commented Jan 7, 2025

  • Introduced get_provisioning_info method in btmesh-nrf-softdevice driver.
  • Added logic to fetch and handle provisioning info in the driver library.
  • Updated UnprovisionedConfiguration struct with a Copy derive to enable getting default configuration.
  • Modified storage initialization to decouple loading from storage from init when driver is ran.

A review of this PR would be appreciated, specifically to check for any unsafe data sharing behavior or potential deadlocks.

Also, should the get_provisioning_info function be part of the BluetoothMeshDriver trait?

- Introduced `get_provisioning_info` method in `btmesh-nrf-softdevice`
  driver.
- Added logic to fetch and handle provisioning info in the driver
  library.
- Updated `UnprovisionedConfiguration` struct with a Copy derive to
  enable getting default configuration.
- Modified storage initialization to decouple loading from storage from
  init when driver is ran.
This commit only exposes the primary unicast address on the api.
Other configuration information is still hidden and can contain
sensitive information (keys).
Copy link
Member

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lulf lulf merged commit ecdf30c into drogue-iot:main Jan 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants