Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the result of unary + to generate rvalue #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mycoboco
Copy link

Given an lvalue as an operand of the unary +, lcc generates an lvalue even if it should not. Thus,

void foo(void)
{
    int x, *p;
    p = &+x;
    +x = 0;
}

it silently accepts this incorrect code.

A simple fix for this issue is to make a RIGHT tree when the result of + is an lvalue, as done in constructing cast trees.

p-rivero added a commit to p-rivero/lcc that referenced this pull request Jul 22, 2021
Implement changes from: drh#19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant