Remove explicit Version MSBuild property #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we're moving to building and pushing packages via GitHub actions, we will take the version from the release itself. This means we don't want it to be specified in the file directly. I like this change as it means we don't have to keep the props file in sync with the current version, simplifying the release process somewhat. We only have to bump the version in the README which directs users to install the current version. That can always be done after release if missed.
The first run of this just completed successfully.
This is a huge improvement over the previous manual release process. Every 12 months I'll need to refresh the NuGet API key in this repo's secrets. |
|
Validated package contents and metadata, including SourceLink and determinism:
|
|
@iamcarbon once you're happy with the changes for 2.9.0 (especially API-changes) we can push out a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're moving to building and pushing packages via GitHub actions, we will take the version from the release itself. This means we don't want it to be specified in the file directly.
I like this change as it means we don't have to keep the props file in sync with the current version, simplifying the release process somewhat. We only have to bump the version in the README which directs users to install the current version. That can always be done after release if missed.