Only when MetaData is read from Keys it should be valid othwise we do…

… a best effort as we don't implement the full set.
drewnoakes · Apr 5, 2024 · e5664b0 · e5664b0
1 parent a9dbdf1
commit e5664b0
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/MetadataExtractor/Formats/QuickTime/QuickTimeMetadataReader.cs b/MetadataExtractor/Formats/QuickTime/QuickTimeMetadataReader.cs
@@ -198,7 +198,7 @@ void MetaDataHandler(AtomCallbackArgs a)
                 }
             }
 
-            void MetaDataTagHandler(AtomCallbackArgs a, string key)
+            void MetaDataTagHandler(AtomCallbackArgs a, string key, bool keyShouldBeValid = false)
             {
                 // Value Atom
                 a.Reader.Skip(8); // uint32 type indicator, uint32 locale indicator
@@ -207,7 +207,10 @@ void MetaDataTagHandler(AtomCallbackArgs a, string key)
                 var dataTypeIndicator = a.Reader.GetUInt32();
                 if (!_supportedAtomValueTypes.Contains((int)dataTypeIndicator))
                 {
-                    GetMetaHeaderDirectory().AddError($"Unsupported type indicator \"{dataTypeIndicator}\" for key \"{key}\"");
+                    if (keyShouldBeValid)
+                    {
+                        GetMetaHeaderDirectory().AddError($"Unsupported type indicator \"{dataTypeIndicator}\" for key \"{key}\"");
+                    }
                     return;
                 }
 
@@ -242,7 +245,10 @@ void MetaDataTagHandler(AtomCallbackArgs a, string key)
                 }
                 else
                 {
-                    GetMetaHeaderDirectory().AddError($"Unsupported ilst key \"{key}\"");
+                    if (keyShouldBeValid)
+                    {
+                        GetMetaHeaderDirectory().AddError($"Unsupported ilst key \"{key}\"");
+                    }
                 }
             }
 
@@ -258,7 +264,7 @@ void MetaDataKeysTagsHandler(AtomCallbackArgs a)
 
                 var key = metaDataKeys[(int)a.Type - 1];
 
-                MetaDataTagHandler(a, key);
+                MetaDataTagHandler(a, key, true);
             }
 
             void MetaDataItemListTagsHandler(AtomCallbackArgs a)