Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnamed reflections now take the model name/alias #264

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

bcmeireles
Copy link
Contributor

Summary

When creating a model for a reflection, if the name config parameter was not set, the reflection would be named Unnamed Reflection inside Dremio.

Description

Instead, the default behavior should be for the reflection to be named after the model name/alias
The default behavior has been changed, it will now set the name attending to the following priority list:

  1. Model config name parameter
  2. Model config alias parameter
  3. Model name

Test Results

Two new tests have been added to the test suit for reflections, one with the alias parameter and another one with the model name

Changelog

  • Added a summary of what this PR accomplishes to CHANGELOG.md

Related Issue

#263

@bcmeireles bcmeireles linked an issue Jan 15, 2025 that may be closed by this pull request
@bcmeireles bcmeireles marked this pull request as ready for review January 15, 2025 17:35
@bcmeireles bcmeireles merged commit 990e846 into dremio:main Jan 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Unnamed reflections should take the model name/alias
3 participants