Unnamed reflections now take the model name/alias #264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When creating a model for a reflection, if the name config parameter was not set, the reflection would be named
Unnamed Reflection
inside Dremio.Description
Instead, the default behavior should be for the reflection to be named after the model name/alias
The default behavior has been changed, it will now set the name attending to the following priority list:
name
parameteralias
parameterTest Results
Two new tests have been added to the test suit for reflections, one with the
alias
parameter and another one with the model nameChangelog
Related Issue
#263