Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of wikis and tags feature #250

Merged
merged 5 commits into from
Jan 13, 2025
Merged

Implementation of wikis and tags feature #250

merged 5 commits into from
Jan 13, 2025

Conversation

99Lys
Copy link
Contributor

@99Lys 99Lys commented Dec 3, 2024 •
edited
Loading

Summary

Wikis and tags feature implementation.

Description

One of dbt's core features is source documentation. Right now, this documentation does not propagate into Dremio’s wiki, leading to two separate sources of truth.

The goal is to display dbt documentation - more specifically, wikis and tags - inside of Dremio.

Test Results

All added tests are running

  • Added tests to check wikis and tags creation for table models
  • Added tests to check wikis and tags creation, update and deletion for view models

Changelog

  • Possibility to integrate wikis and tags by enabling relation option from persist_docs configuration
    • New macro dremio__persist_docs created
    • Views also perform persist_docs macro
    • Integration via REST API

Related Issue

#86
#196

@simonpannek simonpannek marked this pull request as draft December 3, 2024 16:50
@simonpannek simonpannek self-requested a review December 3, 2024 16:50
@bcmeireles bcmeireles self-requested a review December 3, 2024 17:14
@99Lys 99Lys requested a review from howareyouman December 4, 2024 10:25
This was linked to issues Dec 4, 2024
[enhancement] propagate model 's doc & tags to dremio dataset wiki & tags #86
Closed
Add ability to create and update Dremio wiki and tag entries #196
Closed
@99Lys 99Lys changed the title [DRAFT] Implemented wiki management methods and performed simple hardcoded tests Implementation of wikis and tags feature Dec 16, 2024
@99Lys 99Lys force-pushed the DX-98038-DBT-wiki-and-tags-extension-implementation branch from 67892c0 to 79bb2f9 Compare January 6, 2025 13:09
@howareyouman howareyouman changed the base branch from DX-98038-DBT-wiki-and-tags-extension-implementation to main January 8, 2025 10:59
@99Lys 99Lys force-pushed the DX-98038-DBT-wiki-and-tags-extension-implementation branch 2 times, most recently from ec03855 to 2a84e48 Compare January 9, 2025 10:59
@99Lys 99Lys force-pushed the DX-98038-DBT-wiki-and-tags-extension-implementation branch from 2a84e48 to 47f998f Compare January 9, 2025 12:55
@99Lys 99Lys marked this pull request as ready for review January 9, 2025 13:55
howareyouman
howareyouman reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@howareyouman howareyouman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great that you Liliana did it yourself!
All the comments I have are more about style and naming.
I don't see any huge blockers to get it merged soon!

CHANGELOG.md Outdated Show resolved Hide resolved
dbt/adapters/dremio/connections.py Outdated Show resolved Hide resolved
dbt/adapters/dremio/connections.py Outdated Show resolved Hide resolved
dbt/adapters/dremio/connections.py Outdated Show resolved Hide resolved
dbt/adapters/dremio/connections.py Outdated Show resolved Hide resolved
dbt/adapters/dremio/connections.py Outdated Show resolved Hide resolved
dbt/adapters/dremio/connections.py Outdated Show resolved Hide resolved
dbt/include/dremio/macros/adapters/persist_docs.sql Outdated Show resolved Hide resolved
tests/functional/adapter/dremio_specific/test_persist_docs.py Show resolved Hide resolved
bcmeireles
bcmeireles reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@bcmeireles bcmeireles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR!
@howareyouman already pointed pretty much everything, I just have a few questions where I might be lacking context to understand

tests/functional/adapter/dremio_specific/test_persist_docs.py Outdated Show resolved Hide resolved
tests/functional/adapter/dremio_specific/test_persist_docs.py Show resolved Hide resolved
simonpannek
simonpannek previously approved these changes Jan 10, 2025
View reviewed changes
Copy link

@simonpannek simonpannek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! No blockers on my side, just a few small comments!

dbt/adapters/dremio/api/rest/client.py Outdated Show resolved Hide resolved
dbt/adapters/dremio/connections.py Show resolved Hide resolved
tests/functional/adapter/dremio_specific/test_persist_docs.py Show resolved Hide resolved
howareyouman
howareyouman previously approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@howareyouman howareyouman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also answer and finish all the discussions we have here?
Great PR!

@99Lys 99Lys dismissed stale reviews from howareyouman and simonpannek via 2795f54 January 10, 2025 14:01
howareyouman
howareyouman approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@howareyouman howareyouman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@99Lys 99Lys merged commit 50fe20a into dremio:main Jan 13, 2025
3 checks passed
@99Lys 99Lys deleted the DX-98038-DBT-wiki-and-tags-extension-implementation branch January 13, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howareyouman howareyouman howareyouman approved these changes

@bcmeireles bcmeireles Awaiting requested review from bcmeireles

@simonpannek simonpannek Awaiting requested review from simonpannek

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@99Lys @howareyouman @simonpannek @bcmeireles