Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): node maker handle blank #4347

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Dec 20, 2024

What's updated?

Handing spaces before single quotes in formula strings.

How to test?

  1. Write a cross-sheet formula, such as = 'dv-test'!C27
  2. Drop down to fill
  3. Expected result = 'dv-test'!C28 (Before fixed =' 'dv-test''!C28)

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Dec 20, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 20, 2024

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 49 seconds
commit  8f48b7f
info  For more information, see full report

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.07%. Comparing base (7cdd2e6) to head (8f48b7f).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4347      +/-   ##
==========================================
- Coverage   33.10%   33.07%   -0.03%     
==========================================
  Files        2550     2552       +2     
  Lines      131616   131729     +113     
  Branches    29336    29353      +17     
==========================================
+ Hits        43570    43573       +3     
- Misses      88046    88156     +110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir marked this pull request as ready for review December 20, 2024 12:01
@Dushusir Dushusir requested a review from wzhudev as a code owner December 20, 2024 12:01
@Dushusir Dushusir force-pushed the dushusir/formula-bugs1219 branch from c8d8026 to 2474d72 Compare January 6, 2025 07:03
@Dushusir Dushusir merged commit 2fbe824 into dev Jan 6, 2025
9 checks passed
@Dushusir Dushusir deleted the dushusir/formula-bugs1219 branch January 6, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants