Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sidebar visible shoule be false when close #4343

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Dec 20, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@ybzky ybzky requested review from jikkai and Jocs as code owners December 20, 2024 08:17
Copy link

github-actions bot commented Dec 20, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 46 seconds
commit  6fcf2ae
info  For more information, see full report

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.38%. Comparing base (92c7577) to head (6fcf2ae).
Report is 16 commits behind head on dev.

Files with missing lines Patch % Lines
...ckages/ui/src/views/components/sidebar/Sidebar.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4343      +/-   ##
==========================================
- Coverage   33.46%   33.38%   -0.08%     
==========================================
  Files        2509     2515       +6     
  Lines      129495   129820     +325     
  Branches    28972    29005      +33     
==========================================
+ Hits        43332    43338       +6     
- Misses      86163    86482     +319     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant