Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: user facade api & onCommented & cellPointerdown & hide selection #4342

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

lumixraku
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Dec 20, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 20, 2024

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 45 seconds
commit  f2fcb13
info  For more information, see full report

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 81 lines in your changes missing coverage. Please review.

Project coverage is 33.36%. Comparing base (7e36387) to head (f2fcb13).

Files with missing lines Patch % Lines
...es/sheets-ui/src/services/hover-manager.service.ts 0.00% 27 Missing ⚠️
packages/sheets-ui/src/facade/f-workbook.ts 0.00% 12 Missing ⚠️
packages/sheets-ui/src/facade/f-worksheet.ts 0.00% 12 Missing ⚠️
packages/core/src/facade/f-usermanager.ts 0.00% 7 Missing ⚠️
...es/sheets-thread-comment/src/facade/f-worksheet.ts 0.00% 6 Missing ⚠️
...eets-ui/src/controllers/hover-render.controller.ts 0.00% 5 Missing ⚠️
...src/services/selection/selection-render.service.ts 0.00% 4 Missing ⚠️
packages/sheets/src/facade/f-worksheet.ts 0.00% 4 Missing ⚠️
packages/core/src/facade/f-univer.ts 0.00% 2 Missing ⚠️
packages/sheets/src/facade/f-range.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4342      +/-   ##
==========================================
- Coverage   33.36%   33.36%   -0.01%     
==========================================
  Files        2515     2516       +1     
  Lines      129819   129896      +77     
  Branches    29005    29016      +11     
==========================================
+ Hits        43317    43338      +21     
- Misses      86502    86558      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku requested a review from jikkai as a code owner December 20, 2024 11:41
@lumixraku lumixraku changed the title feat: user facade api feat: user facade api & onCommented & cellPointerdown Dec 20, 2024
packages/core/src/facade/f-univer.ts Outdated Show resolved Hide resolved
packages/core/src/facade/f-user.ts Outdated Show resolved Hide resolved
packages/core/src/facade/f-user.ts Outdated Show resolved Hide resolved
packages/sheets-ui/src/facade/f-workbook.ts Outdated Show resolved Hide resolved
@lumixraku lumixraku force-pushed the fix/user-facade-api branch 4 times, most recently from 42dc67d to 4a05311 Compare December 21, 2024 06:39
@lumixraku lumixraku requested a review from wzhudev December 21, 2024 06:40
@lumixraku lumixraku changed the title feat: user facade api & onCommented & cellPointerdown feat: user facade api & onCommented & cellPointerdown & hide selection Dec 21, 2024
@lumixraku lumixraku requested a review from wpxp123456 December 21, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants