Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix merge with move bad case #4274

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix: fix merge with move bad case #4274

wants to merge 3 commits into from

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Dec 10, 2024

close https://github.com/dream-num/univer-pro/issues/3728
close https://github.com/dream-num/univer-pro/issues/3744

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Dec 10, 2024
Copy link

github-actions bot commented Dec 10, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 10, 2024

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 47 seconds
commit  fbbefd2
info  For more information, see full report

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.57%. Comparing base (34fc17d) to head (fbbefd2).

Files with missing lines Patch % Lines
...re/src/docs/data-model/text-x/build-utils/parse.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4274   +/-   ##
=======================================
  Coverage   33.56%   33.57%           
=======================================
  Files        2505     2505           
  Lines      129100   129115   +15     
  Branches    28896    28897    +1     
=======================================
+ Hits        43335    43350   +15     
  Misses      85765    85765           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Dec 10, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Dec 10, 2024
@ybzky ybzky force-pushed the fix-merge-move-col branch from 69d7ab1 to fbbefd2 Compare December 14, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants