-
-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix merge with move bad case #4274
Open
ybzky
wants to merge
3
commits into
dev
Choose a base branch
from
fix-merge-move-col
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
Playwright test resultsDetails 20 tests across 9 suites |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #4274 +/- ##
=======================================
Coverage 33.56% 33.57%
=======================================
Files 2505 2505
Lines 129100 129115 +15
Branches 28896 28897 +1
=======================================
+ Hits 43335 43350 +15
Misses 85765 85765 ☔ View full report in Codecov by Sentry. |
zhaolixin7
added
the
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
label
Dec 10, 2024
VicKun4937
approved these changes
Dec 14, 2024
ybzky
force-pushed
the
fix-merge-move-col
branch
from
December 14, 2024 07:03
69d7ab1
to
fbbefd2
Compare
VicKun4937
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close https://github.com/dream-num/univer-pro/issues/3728
close https://github.com/dream-num/univer-pro/issues/3744
Pull Request Checklist