Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update for React 19 compatibility #4247

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

chore: update for React 19 compatibility #4247

wants to merge 2 commits into from

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Dec 6, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Dec 6, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 6, 2024

Playwright test results

failed  4 failed
passed  17 passed

Details

stats  21 tests across 10 suites
duration  6 minutes, 55 seconds
commit  2050788
info  For more information, see full report

Failed tests

chromium › memory/memory.spec.ts › memory
chromium › visual-comparison/docs/docs-visual-comparison.spec.ts › diff default doc content
chromium › visual-comparison/sheets/sheets-gridlines.spec.ts › sheets no gridlines
chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff default sheet toolbar

@jikkai jikkai force-pushed the chore/react-19 branch 2 times, most recently from 8d9644f to 095e1e6 Compare December 11, 2024 16:33
@jikkai jikkai force-pushed the chore/react-19 branch 3 times, most recently from 6bfdf8d to 287f12e Compare December 19, 2024 12:10
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.38%. Comparing base (769e636) to head (287f12e).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4247   +/-   ##
=======================================
  Coverage   33.38%   33.38%           
=======================================
  Files        2515     2515           
  Lines      129819   129819           
  Branches    29005    29005           
=======================================
  Hits        43338    43338           
  Misses      86481    86481           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant