-
-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(formula): formula update after hide row column #4238
Open
Dushusir
wants to merge
7
commits into
dev
Choose a base branch
from
dushusir/formula1205
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
Playwright test resultsDetails 21 tests across 10 suites |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #4238 +/- ##
==========================================
- Coverage 33.65% 33.64% -0.02%
==========================================
Files 2495 2496 +1
Lines 128247 128309 +62
Branches 28740 28749 +9
==========================================
+ Hits 43167 43170 +3
- Misses 85080 85139 +59 ☔ View full report in Codecov by Sentry. |
Dushusir
force-pushed
the
dushusir/formula1205
branch
from
December 6, 2024 02:58
62f57a2
to
9bdc494
Compare
Dushusir
force-pushed
the
dushusir/formula1205
branch
from
December 7, 2024 03:52
a087219
to
533cd0f
Compare
Dushusir
requested review from
ybzky,
yuhongz,
wzhudev and
VicKun4937
as code owners
December 7, 2024 03:52
Dushusir
requested review from
DR-Univer,
wpxp123456 and
wzhudev
and removed request for
VicKun4937,
wzhudev,
yuhongz,
ybzky and
DR-Univer
December 7, 2024 03:53
zhaolixin7
added
the
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
label
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's updated?
Hiding rows (manually or by filtering) affects the SUBTOTAL formula
How to test?
e.g.
before (dev version)
after
Pull Request Checklist