Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering buttons in table in safari #44

Conversation

haecheonlee
Copy link
Contributor

@haecheonlee haecheonlee commented Apr 13, 2024

Steps to reproduce

  1. Open Safari

- Landing Page
2. Check the position of the circle icon next to each field in a table

- Try it yourself Page
2. Add multiple tables
3. Check the position of the circle icon next to each field in a table
4. Hover the field or title
5. Check the position of buttons

Expected
It should render on the right position

Actual
It renders on different position

Describe your changes

In Safari, applying opacity and z-index to an element within an SVG element can significantly impact its position. It's advisable to avoid directly setting opacity and instead adjust the alpha value of the background-color property. Additionally, the behaviour of z-index can be inconsistent; for instance, an icon may remain visible above another table even when that table is hidden beneath another table. Accordingly, z-index is removed as well.

Notes

This includes the same fix as #35 but also additional fix to render buttons in the right position

Copy link

vercel bot commented Apr 13, 2024

@haecheonlee is attempting to deploy a commit to the dottle's projects Team on Vercel.

A member of the Team first needs to authorize it.

@ClaPalo
Copy link
Contributor

ClaPalo commented Apr 13, 2024

It's exactly the same of #35 but you're missing the Templates page. The issue happens also there.

@haecheonlee
Copy link
Contributor Author

True, I didn't notice that you include the change. I am closing the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants