-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add databases switcher in control panel header #257
base: main
Are you sure you want to change the base?
Conversation
@belyas is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
Since non-generic diagrams each use data types supported by their corresponding database engines, just changing |
Hi @1ilit, so the underlining export to sql won't properly do its work? because these changes have nothing to do with what the final sql would look like, I thought this use case would be as generic case, when the export to sql was clicked with the chosen database, it will trigger proper For enum use case, I see that the current implementation doesn't properly convert enums, I got this sql for Mysql: CREATE TABLE "table_1" (
"id" INTEGER NOT NULL UNIQUE GENERATED BY DEFAULT AS IDENTITY,
"response" ENUM DEFAULT yes,
PRIMARY KEY("id")
); It's exactly what I get when I created a fresh diagram and set same enum. |
Actually the Enum fix for Mysql is done on #252 |
@1ilit can we merge this please, if you don't have any comments on the implementation? as this change will boost the UX. And regarding the underlining specific database engines' implementations have nothing to do with this feature and be done gradually in future PRs |
@belyas sorry but this wont be merged anytime soon, it doesn't even pass the workflows. Regarding the enum issue in mysql there's already pr for it. The issue isn't only about enums in mysql and postgres. There will be a need to provide conversions from all engines to all engines. Feel free to deploy your fork and use that instead. |
for the workflows isn't an issue, I can fix the eslint error, but I didn't get why this won't be merged as it improves the UX and ease choosing the db engines, I also don't see how this work has to do with conversions from/to engines, this has nothing to do with that, or am I wrong and I got things differently? I'd like to have a proper reply @1ilit |
@1ilit I have added conversions to db engines: PostreSQL, MySQL and Sqlite and restricted the db switcher to display only these engines for now, I can add others if this PR can be merged afterwards. |
0ca7470
to
d389c28
Compare
fchgv |
This feature adds a database switcher on the top left beside the chosen database to give current user ability to switch the databases easily as we had such situation and we had to redo everything from scratch just the chosen database was not the right one.
Here how it looks like when it's open:
Here are example of different outputs based on chosen database: