Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor component structure of modal #124

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

phamhieu275
Copy link
Contributor

@phamhieu275 phamhieu275 commented May 22, 2024

I have restructured the source code of the modal component with the following purposes:

  • There is a modal manager file to handle the overall management of modals in the system.
  • When adding a new modal, the logic will be written separately within that modal.
  • For existing export modals that share a common part to rename file, I have created a base modal for a common part.
  • I have combined the image and SQL export functionalities into a single modal, allowing the selection of corresponding formats.

Please review.
Thank you very much.

Copy link

vercel bot commented May 22, 2024

@cmc-pvhieu is attempting to deploy a commit to the dottle's projects Team on Vercel.

A member of the Team first needs to authorize it.

@1ilit
Copy link
Member

1ilit commented May 22, 2024

Thank you! Could you please submit each feature in a separate PR so that they can each be reviewed separately.

And no need for drawdb and pdf modals. The modals are there to allow the user to see what they're exporting. Since I'm not planning to have a pdf viewer there's no need to the modal

@phamhieu275
Copy link
Contributor Author

@1ilit

I have just separate and keep only refactored code of modal component.
When exporting pdf or drawdb data, we cannot edit the file name.
Other export functions can be edited, so I created a pdf and drawdb modal to unify the ability to rename exported files.

@phamhieu275 phamhieu275 changed the title Refactor component structure of modal and add export excel feature Refactor component structure of modal May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants