fix: Support TLS for Memcached without password authentication #5085
Conversation
romange
left a comment
romange
left a comment
There was a problem hiding this comment.
@vyavdoshenko thank you for solving it so quickly! 🙏🏼
| ssl_context.verify_mode = ssl.CERT_NONE | ||
|
|
||
| # Output port information for diagnostics | ||
| print(f"Connecting to memcached port: {server.mc_port} on host: 127.0.0.1") |
There was a problem hiding this comment.
nit: we do not use prints in tests - only logging.info/debug etc
|
@vyavdoshenko not urgent - can wait for next week, but i just I realized we fixed it wrong. We could still provide a password but always mark memcached connections as authenticated. in fact it's not related to TLS, this should be done regardless because otherwise nobody can use memcache port if password is defined for the datastore. I think this is what @kostasrim tried to say yesterday . |
I see. I will fix it. |
Fixes: #5084
Dragonfly required password authentication when TLS was enabled. However, the Memcached protocol doesn't support password authentication, making it impossible to use Memcached with TLS.
Modified the
ValidateServerTlsFlags()function to allow TLS without authentication when the Memcached port is enabled.