add wfh mode & test mode also update processSpecialReport #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonH
requested changes
Aug 10, 2021
Comment on lines
+7
to
+8
| is_test=false |
There was a problem hiding this comment.
please follow naming style
camel-style & meaningful
e.g. isWFH, isTestingENV
Comment on lines
+11
to
+16
| //////////////////////////////////////////////// | ||
| // Where will you work today? WFH = ture / false | ||
| const is_wfh = ( "true" == process.env.is_wfh) | ||
| const is_test = ( "true" == process.env.is_test) | ||
| //////////////////////////////////////////////// | ||
|
|
There was a problem hiding this comment.
should be initialized in main function
Comment on lines
-43
to
+49
| headless: true, | ||
| headless: !is_test, |
There was a problem hiding this comment.
please follow naming style
camel-style & meaningful
e.g. isWFH, isTestingENV
Comment on lines
+7
to
+8
| is_test=false |
There was a problem hiding this comment.
value should not be defined in .template file
Comment on lines
+120
to
+130
| if (is_test) { | ||
| await _page.waitForTimeout(2000); | ||
| await _page.waitForSelector('input[value="登入"]', { timeout: 60000 }); | ||
| await _page.click('input[value="登入"]'); | ||
| } | ||
|
|
||
| else { | ||
| await _page.waitForSelector('input[value="Sign in"]', { timeout: 60000 }); | ||
| await _page.click('input[value="Sign in"]'); | ||
| } | ||
|
|
There was a problem hiding this comment.
if..elseindent, should be like below
if (xxxxx) {
....
} else {
....
}
- in
testingmode, language should beenglish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.