Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WINHTTP_NO_CLIENT_CERT_CONTEXT Null ptr addition #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

WINHTTP_NO_CLIENT_CERT_CONTEXT Null ptr addition #16

wants to merge 3 commits into from

Conversation

bmparson
Copy link

@bmparson bmparson commented Dec 7, 2021

WINHTTP_OPTION_CLIENT_CERT_CONTEXT fails when set to Null pointer which is what the WINHTTP_NO_CLIENT_CERT_CONTEXT macro does.

mlipok
mlipok suggested changes Dec 8, 2021
View reviewed changes
Copy link

@mlipok mlipok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for beter code reading please add spaces:
_WinHttpSetOption($hrequest, $WINHTTP_OPTION_CLIENT_CERT_CONTEXT, $WINHTTP_NO_CLIENT_CERT_CONTEXT, 0)

mlipok
mlipok reviewed Dec 8, 2021
View reviewed changes
Copy link

@mlipok mlipok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for better cod reading please add spaces
If $iSize < 1 And Not ($iOption = $WINHTTP_OPTION_CLIENT_CERT_CONTEXT And $vSetting = Null) Then

@bmparson
Copy link
Author

bmparson commented Dec 8, 2021

made the requested changes

rcmaehl added a commit to rcmaehl/autoit-winhttp that referenced this pull request Oct 27, 2022
@rcmaehl
Merge dragana-r/pull/16
41a672f 
Credit: @bmparson
rcmaehl added a commit to rcmaehl/autoit-winhttp that referenced this pull request Oct 27, 2022
@rcmaehl
Merge dragana-r/pull/16
b6e7a45 
Credit: @bmparson
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlipok mlipok mlipok requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmparson @mlipok