Pull user specific API URL from json file api_location property #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Can you change this so it uses .get() instead of [] and defaults to the old value please. |
|
Done! Probably worth mentioning for anyone reading this that this isn't a full solution for the API Location error, rather it allows the user to alter the api_location string in their JSON to the correct one. The user still has to determine the correct URL themselves. |
dpjanes
approved these changes
May 22, 2017
|
I'm going to add documentation on the locations. I'm not using this enough to make a better solution yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the user-specific API URL to be stored in the smartthings.json configuration file in the api_location property. Partial workaround for #8