Skip to content

Conversation

@chbrky
Copy link

@chbrky chbrky commented Nov 9, 2024

Allows user to right-click on revealed clue to automatically paste answer and clue into search engine. Implements Add Shortcut to Copy on Grid #313

…swer and clue into search engine. Implements Add Shortcut to Copy on Grid downforacross#313
@vercel
Copy link

vercel bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
downforacross.com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 11:43pm

@stevenhao
Copy link
Member

thanks for the PR!

  1. i think right-click to copy is fine (maybe show a little toast saying clue & text "Copied to clipboard") but opening google search in a new tab is a bit much...
  2. maybe the trigger should be right clicking the clue in the clue list, instead of on the grid? the grid already uses right click for pings.

@chbrky
Copy link
Author

chbrky commented Nov 12, 2024

Thanks for reviewing the PR!

  1. What if we still do a Google search but don't focus on the new tab created? I think it would be easier for the user if they had a bunch of answers/clues they wanted to look up rather than having to repeatedly switch tabs.
  2. I totally agree with the right-click already being used with the ping on the grid, and I don't like the multi-use, but I believe copying from the clue list isn't exactly intuitive (I tried to implement it while working on it early). The ping still works, except when a clue is revealed, then it will search for the answer. My question is how often are people pinging revealed answers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants