Add support for tools and return an output object #1733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlouf
reviewed
Aug 22, 2025
RobinPicard
force-pushed
the
add_tools_support
branch
from
34b3239 to
a2f0fe6
Compare
RobinPicard
force-pushed
the
add_tools_support
branch
2 times, most recently
from
204406e to
455b26d
Compare
RobinPicard
force-pushed
the
add_tools_support
branch
from
455b26d to
9554b2c
Compare
RobinPicard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that for the tools definition, the user could provide a list of either of those:
The
toolsargument would be provided in the same places as theoutput_type. In the generator, there is a step to turn the user tools input into a list of dicts (a bit similar to how we are compiling the output_type for steerable models).Then, each model's type adapter would have a
format_toolsmethod that would turn this standardized tool dict definition into the argument expected by the model.Each model, upon receiving a response for the text generation, would then return an
Outputobject (distinguishing between regular responses and tool calls).This
Outputinstance returned by the model could then be used as a message in aChatinput.Something yet to be figured out is how we handle streaming.