Remove NetFX-specific dead code from DWriteForwarder compilation#10641
Open
h3xds1nz wants to merge 1 commit intodotnet:mainfrom
Open
Remove NetFX-specific dead code from DWriteForwarder compilation#10641h3xds1nz wants to merge 1 commit intodotnet:mainfrom
h3xds1nz wants to merge 1 commit intodotnet:mainfrom
Conversation
dotnet-policy-service
bot
requested review from
Kuldeep-MS,
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10641 +/- ##
===================================================
+ Coverage 11.22814% 11.27290% +0.04476%
===================================================
Files 3352 3352
Lines 668000 668027 +27
Branches 74980 74968 -12
===================================================
+ Hits 75004 75306 +302
+ Misses 591745 591466 -279
- Partials 1251 1255 +4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes
utilsfile that's included inmainbut doesn't actually get compiled into the library as none of the code is used. It contains NetFX specific code anyways (including the undocumentedCOMPLUS_InstallRootthat can be used to swap NetFX path).Customer Impact
Cleaner codebase for developers.
Regression
No.
Testing
Local build.
Risk
None, the code is
NetFX-specific and unused.Microsoft Reviewers: Open in CodeFlow