Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TabPage tests and cleanup code #1482

Merged
4 commits merged into from
Jul 29, 2019
Merged

Add TabPage tests and cleanup code #1482

4 commits merged into from
Jul 29, 2019

Conversation

hughbe
Copy link
Contributor

@hughbe hughbe commented Jul 26, 2019

Microsoft Reviewers: Open in CodeFlow

@hughbe hughbe requested a review from a team as a code owner July 26, 2019 11:25
Copy link
Contributor

@zsd4yr zsd4yr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending Igor's review

Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflict

@ghost ghost added the 📭 waiting-author-feedback The team requires more information from the author label Jul 29, 2019
@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Jul 29, 2019
@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #1482 into master will increase coverage by 0.08305%.
The diff coverage is 67.34694%.

@@                 Coverage Diff                 @@
##              master       #1482         +/-   ##
===================================================
+ Coverage   25.03639%   25.11944%   +0.08305%     
===================================================
  Files            785         785                 
  Lines         268613      268553         -60     
  Branches       37958       37959          +1     
===================================================
+ Hits           67251       67459        +208     
+ Misses        196625      196358        -267     
+ Partials        4737        4736          -1
Flag Coverage Δ
#Debug 25.11944% <67.34694%> (+0.08305%) ⬆️
#production 25.11944% <67.34694%> (+0.08305%) ⬆️
#test 100% <ø> (ø) ⬆️

@ghost
Copy link

ghost commented Jul 29, 2019

Hello @RussKie!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@RussKie RussKie added this to the 3.0.0-Preview8 milestone Jul 29, 2019
@ghost ghost merged commit d2ebed1 into dotnet:master Jul 29, 2019
@RussKie RussKie added the code cleanup cleanup code for unused apis/properties/comments - no functional changes. label Jul 29, 2019
@hughbe hughbe deleted the tabpage-tests branch July 29, 2019 08:20
@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
code cleanup cleanup code for unused apis/properties/comments - no functional changes. :octocat: automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants