Break up Control class #1475
Merged
Break up Control class #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Break out all of the nested classes in Control into separate files. Pull most of the field names into line with coding styles. Clean up some comments and collapse some code. Remove dead code. VS was choking with all of the style violations in Control. This should hopefully make working on Control a lot less painful and set us up for further cleanup. No functional changes were made.
hughbe
reviewed
Jul 26, 2019
src/System.Windows.Forms/src/System/Windows/Forms/Control.AxSourcingSite.cs
Show resolved
Hide resolved
hughbe
reviewed
Jul 26, 2019
src/System.Windows.Forms/src/System/Windows/Forms/Control.AxSourcingSite.cs
Outdated
Show resolved
Hide resolved
hughbe
reviewed
Jul 26, 2019
src/System.Windows.Forms/src/System/Windows/Forms/Control.ControlAccessibleObject.cs
Show resolved
Hide resolved
hughbe
reviewed
Jul 26, 2019
src/System.Windows.Forms/src/System/Windows/Forms/Control.ControlAccessibleObject.cs
Show resolved
Hide resolved
hughbe
reviewed
Jul 26, 2019
src/System.Windows.Forms/src/System/Windows/Forms/Control.ControlAccessibleObject.cs
Outdated
Show resolved
Hide resolved
hughbe
reviewed
Jul 26, 2019
src/System.Windows.Forms/src/System/Windows/Forms/Control.ControlAccessibleObject.cs
Outdated
Show resolved
Hide resolved
hughbe
reviewed
Jul 26, 2019
src/System.Windows.Forms/src/System/Windows/Forms/Control.ControlCollection.cs
Outdated
Show resolved
Hide resolved
|
🙏 bless up |
zsd4yr
reviewed
Jul 26, 2019
zsd4yr
approved these changes
Jul 26, 2019
|
I found myself discovering all sorts of other cleanups / minor tweaks we could make! Great start; |
Codecov Report
@@ Coverage Diff @@
## master #1475 +/- ##
==================================================
- Coverage 25.04917% 24.9799% -0.06927%
==================================================
Files 770 785 +15
Lines 268939 268664 -275
Branches 37962 37960 -2
==================================================
- Hits 67367 67112 -255
+ Misses 196836 196821 -15
+ Partials 4736 4731 -5
|
zsd4yr
approved these changes
Jul 26, 2019
RussKie
added
the
code cleanup
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break out all of the nested classes in Control into separate files.
Pull most of the field names into line with coding styles.
Clean up some comments and collapse some code.
Remove dead code.
VS was choking with all of the style violations in Control. This should hopefully make working on Control a lot less painful and set us up for further cleanup.
No functional changes were made.
Microsoft Reviewers: Open in CodeFlow