Re-enable some analyzers #12529
Open
Re-enable some analyzers #12529
+282
−295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a few marked as TODO. This makes them back into warnings with the exception of IDE0059 which is "Unnecessary assignment of a value". That is now a suggestion. Some of the fixes for IDE0059 are in this commit, others will follow as there are a lot of failures on that one.
|
src\System.Windows.Forms.Design\tests\UnitTests\GlobalSuppressions.cs(6,83): error SA1404: (NETCORE_ENGINEERING_TELEMETRY=Build) Code analysis suppression should have justification |
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ToolStripActionList.cs
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ToolStripActionList.cs
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12529 +/- ##
====================================================
- Coverage 97.04530% 75.74431% -21.30099%
====================================================
Files 1166 3157 +1991
Lines 352219 636061 +283842
Branches 5319 46999 +41680
====================================================
+ Hits 341812 481780 +139968
- Misses 9660 150819 +141159
- Partials 747 3462 +2715
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few marked as TODO. This makes them back into warnings with the exception of IDE0059 which is "Unnecessary assignment of a value". That is now a suggestion. Some of the fixes for IDE0059 are in this commit, others will follow as there are a lot of failures on that one.
Microsoft Reviewers: Open in CodeFlow