[release/9.0] Call Correct HtmlHelp Overload #12519
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
NET9 would need a newer cswin32 metadata, wouldn't it? |
lonitra
reviewed
Nov 22, 2024
| @@ -49,7 +49,7 @@ | |||
| Microsoft.NET.Sdk.IL.targets requires definition of MicrosoftNETCoreILAsmVersion | |||
| --> | |||
| <MicrosoftNETCoreILAsmVersion>$(MicrosoftNETCoreILAsmPackageVersion)</MicrosoftNETCoreILAsmVersion> | |||
| <MicrosoftWindowsCsWin32PackageVersion>0.3.75-beta</MicrosoftWindowsCsWin32PackageVersion> | |||
| <MicrosoftWindowsCsWin32PackageVersion>0.3.106</MicrosoftWindowsCsWin32PackageVersion> | |||
There was a problem hiding this comment.
Bumping this version requires same changes to occur as in #12290
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/9.0 #12519 +/- ##
======================================================
- Coverage 97.00790% 74.83065% -22.17725%
======================================================
Files 1066 3022 +1956
Lines 345811 630203 +284392
Branches 5038 46791 +41753
======================================================
+ Hits 335464 471585 +136121
- Misses 9625 155238 +145613
- Partials 722 3380 +2658
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lonitra
added
🚫 * NO-MERGE *
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12511 to release/9.0
/cc @lonitra
Customer Impact
Customers are no longer able to launch help page when providing their .chm file and a topic ID.
Testing
Manual testing with repro scenario
Risk
Low. The fix involves correcting a HtmlHelp call to calling the same overload as we did in .NET 8. Other changes are required as part of bumping cswin32 version which contains a fix for HtmlHelp definition.
Microsoft Reviewers: Open in CodeFlow