Bump up NuGet Packs and apply new Analyzer Rules. #12512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyKuhne
requested changes
Nov 20, 2024
| @@ -10,25 +10,25 @@ internal readonly partial struct WPARAM | |||
| public static unsafe implicit operator void*(WPARAM value) => (void*)value.Value; | |||
| public static unsafe implicit operator WPARAM(void* value) => new((nuint)value); | |||
|
|
|||
| public static explicit operator HWND(WPARAM value) => (HWND)(nint)value.Value; | |||
| public static explicit operator WPARAM(HWND value) => new((nuint)value.Value); | |||
| public static unsafe explicit operator HWND(WPARAM value) => (HWND)(nint)value.Value; | |||
There was a problem hiding this comment.
nit: at this point, should just make the struct itself unsafe
| @@ -50,7 +50,7 @@ public unsafe CreateDcScope( | |||
| } | |||
|
|
|||
| public static implicit operator HDC(in CreateDcScope scope) => scope.HDC; | |||
| public static implicit operator HGDIOBJ(in CreateDcScope scope) => (HGDIOBJ)(scope.HDC.Value); | |||
| public static unsafe implicit operator HGDIOBJ(in CreateDcScope scope) => (HGDIOBJ)(scope.HDC.Value); | |||
There was a problem hiding this comment.
There really should be an implicit operator on HDC to convert to HGDIOBJ as that cast is always legit. Then this can just be scope.HDC.
| @@ -30,7 +30,7 @@ public CreatePenScope(Color color, int width = 1) => | |||
| HPEN = PInvokeCore.CreatePen(PEN_STYLE.PS_SOLID, width, color); | |||
|
|
|||
| public static implicit operator HPEN(in CreatePenScope scope) => scope.HPEN; | |||
| public static implicit operator HGDIOBJ(in CreatePenScope scope) => (HGDIOBJ)scope.HPEN.Value; | |||
| public static unsafe implicit operator HGDIOBJ(in CreatePenScope scope) => (HGDIOBJ)scope.HPEN.Value; | |||
There was a problem hiding this comment.
As mentioned above, should have an implicit conversion operator on HPEN to go to HGDIOBJ.
src/System.Private.Windows.Core/src/Windows/Win32/Graphics/Gdi/HGDIOBJ.cs
Outdated
Show resolved
Hide resolved
src/System.Private.Windows.Core/src/Windows/Win32/UI/WindowsAndMessaging/HCURSOR.cs
Outdated
Show resolved
Hide resolved
...s.Design/src/System/Windows/Forms/Design/Behavior/BehaviorService.AdornerWindow.MouseHook.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/Input/Cursor.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/NativeWindow.WindowClass.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ToolTip/ToolTip.cs
Outdated
Show resolved
Hide resolved
| @@ -93,15 +93,15 @@ | |||
| <PropertyGroup> | |||
| <CSharpIsNullAnalyzersVersion>0.1.495</CSharpIsNullAnalyzersVersion> | |||
| <DotNetAnalyzersDocumentationAnalyzersVersion>1.0.0-beta.59</DotNetAnalyzersDocumentationAnalyzersVersion> | |||
| <MicrosoftCodeAnalysisAnalyzersVersion>3.11.0-beta1.24219.2</MicrosoftCodeAnalysisAnalyzersVersion> | |||
| <MicrosoftCodeAnalysisCommonPackageVersion>4.10.0-3.final</MicrosoftCodeAnalysisCommonPackageVersion> | |||
| <MicrosoftCodeAnalysisAnalyzersVersion>3.12.0-beta1.24559.1</MicrosoftCodeAnalysisAnalyzersVersion> | |||
There was a problem hiding this comment.
We'll want to update the versions for WPF as well. I'll sync with you on that.
dotnet-policy-service
bot
added
📭 waiting-author-feedback
lonitra
reviewed
Nov 22, 2024
| @@ -2318,8 +2318,7 @@ private unsafe void WndProc(ref Message message) | |||
|
|
|||
| using Graphics graphics = paintScope.HDC.CreateGraphics(); | |||
|
|
|||
| IWin32Window? window = GetCurrentToolWindow(); | |||
| if (window is not null) | |||
| if (GetCurrentToolWindow() is Control window) | |||
There was a problem hiding this comment.
Should this still be IWin32Window? Below code seems to indicate it may not always be a Control
Comment on lines
+19
to
+20
| || (OsVersion.IsWindows10_1607OrGreater() | ||
| && (bool)PInvoke.AreDpiAwarenessContextsEqual(this, dpiContext)); |
There was a problem hiding this comment.
nit for readability:
Suggested change
| || (OsVersion.IsWindows10_1607OrGreater() | |
| && (bool)PInvoke.AreDpiAwarenessContextsEqual(this, dpiContext)); | |
| || (OsVersion.IsWindows10_1607OrGreater() | |
| && (bool)PInvoke.AreDpiAwarenessContextsEqual(this, dpiContext)); |
KlausLoeffelmann
force-pushed
the
BumpUpNuGets
branch
from
756c4e6
to
e40aa6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the NuGet packages to the latest versions and applies the new respective Analyzer Rules.
Microsoft Reviewers: Open in CodeFlow