fix #12358 [HDPI] The "document" text in the “Generating Previews” dialog is truncated at >200% DPI

[Epica3055]

Fixes #12358

Proposed changes

• Revert PR Create AccessibleObject for PrintStatusDialog #11523

Regression?

• Yes

Risk

• low

Screenshots

Before

After

Test methodology

• manual

Microsoft Reviewers: Open in CodeFlow

[codecov]

Codecov Report

Attention: Patch coverage is 5.71429% with 33 lines in your changes missing coverage. Please review.

Project coverage is 75.73717%. Comparing base (e8a65f9) to head (a23da97).
Report is 105 commits behind head on main.

Additional details and impacted files

@@                 Coverage Diff                 @@
##                main      #12363         +/-   ##
===================================================
+ Coverage   75.64857%   75.73717%   +0.08859%     
===================================================
  Files           3120        3159         +39     
  Lines         635396      636113        +717     
  Branches       46933       47001         +68     
===================================================
+ Hits          480668      481774       +1106     
+ Misses        151270      150868        -402     
- Partials        3458        3471         +13     

Flag	Coverage Δ
Debug	75.73717% <5.71429%> (+0.08859%)	⬆️
integration	18.17861% <0.00000%> (-0.10380%)	⬇️
production	49.30080% <5.71429%> (+0.09681%)	⬆️
test	97.04530% <ø> (+0.01837%)	⬆️
unit	46.51736% <5.71429%> (+0.36854%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[LeafShi1]

LGTM!

[lonitra]

Changes seem fine to me, but could we do testing on this to make sure there are no other regressions

[Philip-Wang01]

Tested private dlls for this PR, here is the result.

For 11456, issue3(An error was detected by using Accessibility Insight tool for the "Page 1 of document" pattern) has been fixed. Currently only Narrator can't announce “Generating Previews”, NVDA and JAWS can announce it correctly, and isDialog and AccessibleName properties are correct.

For 12358, three regression HDPI issues (compared with the behaviors in .NET 8.0) still repro. See details in the team's channel.

[Tanya-Solyanik]

@Epica3055 - what accessible properties differ between the Label and the LinkLabel? Let's review them and any important property, like ControlType, can be fixed in a custom accessible object.

[Epica3055]

@Tanya-Solyanik
I created a demo project.

[Tanya-Solyanik]

Name and Automation Id properties are in your control, it will be set here - internal Label _messageLabel;
The problem is the child heirarchy. Could you please try to get rid of it, start by not having any links, then if that does not work, implement a custom accessible object that overrides the Navigation methods - FragmentNavigate, GetChild, GetChildCount

[Tanya-Solyanik]

Changes look good, could you please get them tested under different screen readers

[Philip-Wang01]

Tested private dlls for this PR, here is the result.

For #11456, One behavior needs to be confirmed. Narrator still can't announce “Generating Previews”, NVDA announce it correctly, and isDialog and AccessibleName properties are correct.

For #12358, all HDPI issues have been fixed and there are no new regressions.

[Tanya-Solyanik]

Please investigate how to override AccessibleRole and ControlType for the new object

[Epica3055]

@Tanya-Solyanik

When we focus on LinkLabel using AccessibleTool, we actually focus on Link.
So we need to change Link AccessibleRole , please review latest commit in this pr to see if that's acceptable.

[Tanya-Solyanik]

Can we set the Control.AccessibleRole property instead?

[Epica3055]

I don't think we can.

JAWS announce “Page 1 of document” with the suffix changed from text to link, it announce “page 1 of document link”

The real problem here is in Link, not in LinkLabel.

It seems impossible to change Link.AccessibleRole from outside. So I changed our code to let Link.AccessibleRole rely on LinkLabel so that I can customize Link.AccessibleRole.

[Tanya-Solyanik]

Note for the future - we might have other instances of dialogs where we need a focusable label, we'll "un-nest" this class if needed.