Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten long inline comments REVIEW (4th) DRAFT #12139

Draft
wants to merge 811 commits into
base: main
Choose a base branch
from

Conversation

paul1956
Copy link
Contributor

@paul1956 paul1956 commented Sep 14, 2024

Shorten long inline comments

Proposed changes

  • Wrap and in some cases move up a line, long inline comments.

Customer Impact

  • None

Regression?

  • No

Risk

  • None - no code changes
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 85.98832% with 336 lines in your changes missing coverage. Please review.

Project coverage is 75.87633%. Comparing base (441fb2a) to head (562a3a6).
Report is 8 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12139         +/-   ##
===================================================
+ Coverage   75.74060%   75.87633%   +0.13572%     
===================================================
  Files           3157        3163          +6     
  Lines         636104      637884       +1780     
  Branches       47003       47060         +57     
===================================================
+ Hits          481789      484003       +2214     
+ Misses        150854      150420        -434     
  Partials        3461        3461                 
Flag Coverage Δ
Debug 75.87633% <85.98832%> (+0.13572%) ⬆️
integration 18.15973% <8.15494%> (-0.01520%) ⬇️
production 49.52507% <65.95528%> (+0.21831%) ⬆️
test 97.05741% <99.92928%> (+0.01206%) ⬆️
unit 46.74547% <59.34959%> (+0.22616%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@Tanya-Solyanik Tanya-Solyanik added the draft draft PR label Sep 14, 2024
@dotnet-policy-service dotnet-policy-service bot removed the draft draft PR label Sep 15, 2024
@paul1956 paul1956 changed the title Shorten long inline comments DRAFT Shorten long inline comments REVIEW (5th) DRAFT Sep 16, 2024
@paul1956 paul1956 changed the title Shorten long inline comments REVIEW (5th) DRAFT Shorten long inline comments REVIEW (4th) DRAFT Sep 19, 2024
@paul1956
Copy link
Contributor Author

@Tanya-Solyanik could you set this one to draft please.

lonitra and others added 30 commits November 12, 2024 15:37
…' into Shorten-long-inline-comments-Review-4th
…' into Shorten-long-inline-comments-Review-4th
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft draft PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants