Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/runtime #45500

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Dec 17, 2024

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport: from 10.0.0-alpha.1.24575.2 to 10.0.0-alpha.1.24613.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)
    • Microsoft.SourceBuild.Intermediate.emsdk: from 10.0.0-alpha.1.24575.2 to 10.0.0-alpha.1.24613.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)

From https://github.com/dotnet/runtime

  • Subscription: cedddd63-79f5-4e7e-6d46-08dc434c4948
  • Build: 20241217.1
  • Date Produced: December 17, 2024 1:08:39 PM UTC
  • Commit: 9482c1ed378dfde2f540b99cb99685396b3bd4c2
  • Branch: refs/heads/main

…1216.9

Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24616.1 -> To Version 10.0.0-alpha.1.24616.9

Dependency coherency updates

Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk
 From Version 10.0.0-alpha.1.24575.2 -> To Version 10.0.0-alpha.1.24613.1 (parent: Microsoft.NETCore.App.Runtime.win-x64
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Dec 17, 2024
@akoeplinger akoeplinger enabled auto-merge (squash) December 17, 2024 09:33
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/runtime:

@dotnet/dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

…1217.1

Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24616.1 -> To Version 10.0.0-alpha.1.24617.1
@marcpopMSFT
Copy link
Member

The remaining failure is on linux and the workloads test. It's expecting wasi-experimental. I wonder if we should just remove that check as it was added here: https://github.com/dotnet/sdk/pull/42062/files to fix the test but it doesn't seem needed anymore.

CC @dsplaisted @lewing @steveisok on thoughts as to why multi-targeting on linux would report back wasi-experimental as that seems like our prior issues with dotnet restore. I'm going to proactively remove that since it's the holidays and this is main.

@akoeplinger
Copy link
Member

akoeplinger commented Dec 17, 2024

@marcpopMSFT I looked at this a bit and filed #45516 and disabled the tests for now. From what I can see we seem to be looking at the number of packs and suggest the workload with the lowest number of packs:

internal static WorkloadSuggestion GetBestSuggestion(ICollection<WorkloadSuggestion> suggestions) => FindBest(
suggestions,
(x, y) => y.ExtraPacks - x.ExtraPacks,
(x, y) => y.Workloads.Count - x.Workloads.Count);
/// <summary>
/// Gets the suggestion with the lowest number of extra packs and lowest number of workload IDs.
/// </summary>
public WorkloadSuggestion GetBestSuggestion() => GetBestSuggestion(UnsortedSuggestions);

It doesn't make much sense to me.

@dotnet-maestro dotnet-maestro bot merged commit e5fc5f0 into main Dec 17, 2024
42 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-163c8da4-dc7c-4c8e-a22c-ebe27bc65f2c branch December 17, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants