Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable test timeout dump collection #44730

Open
wants to merge 6 commits into
base: release/9.0.1xx
Choose a base branch
from

Conversation

marcpopMSFT
Copy link
Member

@marcpopMSFT marcpopMSFT commented Nov 7, 2024

I do not know the history on why we launch our tests with dotnet-exec. We may hae to change the arguments to match the above commands that we use on netfx (and simplify to just use one).

I'm starting with this just to see if it'll work.

Also open question is where will the dump end up.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Nov 7, 2024
@marcpopMSFT
Copy link
Member Author

This doesn't appear to work on non-windows:
The test source file "/private/tmp/helix/working/AB8E0979/w/B5F809E7/e/trx" provided was not found.

And any test that requires msbuildforwardingapp doesn't appear to work correctly within the dotnet test execution.

Applying a fix for the path variable as it was adding quotes that weren't meant to be there.

@marcpopMSFT
Copy link
Member Author

@dsplaisted some of the other failures doing this are because we end up getting the host from the environment but that's now testhost.exe: https://github.com/dotnet/sdk/blob/main/src/Cli/Microsoft.DotNet.Cli.Utils/ForwardingAppImplementation.cs#L99

Is there a better way to find dotnet.exe that we already have in our test infrastructure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants