[browser][coreCLR] apply runtime options #123331
Open
+93
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
Contributor
|
Tagging subscribers to this area: @agocke, @jeffschwMSFT, @elinor-fung |
This was referenced Jan 18, 2026
maraf
approved these changes
Jan 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the CoreCLR initialization process for browser/WASM to pass runtime configuration options directly as function parameters instead of through environment variables. This enables linker features to work properly by making runtime options available during initialization.
Changes:
- Updated CoreCLR initialization to accept runtime configuration properties as parameters instead of environment variables
- Added support for merging
runtimeConfig.runtimeOptions.configPropertiesin loader configuration - Introduced new
BrowserHost_CreateHostContractfunction to separate host contract creation from initialization
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/native/libs/Common/JavaScript/types/ems-ambient.ts | Updated type definitions to add CharPtrPtr import and new function signatures for CreateHostContract and InitializeCoreCLR |
| src/native/corehost/browserhost/loader/config.ts | Added merging and normalization logic for runtimeConfig.runtimeOptions.configProperties |
| src/native/corehost/browserhost/libBrowserHost.footer.js | Refactored to remove environment variable setup from JS layer and updated dependency declarations |
| src/native/corehost/browserhost/host/host.ts | Implemented new initializeCoreCLR that builds runtime properties and passes them to C++ via parameters |
| src/native/corehost/browserhost/browserhost.cpp | Refactored to accept properties as function parameters instead of reading from environment variables |
fix manual rollup run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that linker features work