Fix the MinimumPlatformVersion for Mac Catalyst in the Mach-O writer. #122339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constant didn't match the comment, and since the comment is correct, fix the constant.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the Mach-O object writer where the minimum platform version constant for Mac Catalyst incorrectly specified 15.2.0 (0x0F_02_00) instead of the intended 15.0.0 (0x0F_00_00), making the constant match its comment.
Key Changes
- Corrected the MinimumPlatformVersion constant from
0x0F_02_00to0x0F_00_00for Mac Catalyst
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constant didn't match the comment, and since the comment is correct, fix the constant.