-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close stale PRs #75963
base: main
Are you sure you want to change the base?
Close stale PRs #75963
Conversation
- not: | ||
isDraft | ||
- noActivitySince: | ||
days: 14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd propose a bit longer than 14 days, since that's probably going to auto-close all our PRs that get opened around Christmas/New Years. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to give them a nudge after 2 weeks, then a bit more time to respond before closing?
- noActivitySince: | ||
days: 14 | ||
actions: | ||
- closePullRequest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have this switch things back to draft instead? Or label the PRs closed this way? My concern being if somebody is out for a bit, it'll be harder for them to figure out which things got auto-closed when they come back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to exempt the Roslyn team?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Let's just move to closed after a month. If you're out a month, you should figure out what to do with your open PRs anyways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not exempt the team. We're both a large source of this already, and we should be able to complete things within a month, or take them out if we're making no progress on them.
No description provided.