Fix typo in Microsoft.NETCore.Compilers props file #25220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinujoseph
approved these changes
Mar 5, 2018
jcouv
approved these changes
Mar 5, 2018
|
@jaredpar for ask mode approval |
jaredpar
approved these changes
Mar 5, 2018
jasonmalinowski
approved these changes
Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer scenario
Install the Microsoft.NETCore.Compilers package into a .NET Core project and build. The build fails because there is an MSBuild syntax error in the default props file from the package.
Bugs this fixes
#25219
Workarounds, if any
None
Risk
This props file is only used in this package.
Performance impact
None
Is this a regression from a previous update?
No, this package has never been public before.
Root cause analysis
This package isn't tested in any of our unit tests. I tested the package manually, but must have made a typo after testing it.
How was the bug found?
Found in this PR when trying to bring in a new compiler #25179