Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare the generic types of source and destination to ensure they are identical before raising CA2009 #7382

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Compare the generic types of source and destination to ensure they are identical before raising CA2009 #7382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...lyzers/ImmutableCollections/DoNotCallToImmutableCollectionOnAnImmutableCollectionValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ public override void Initialize(AnalysisContext context)
}

if (invocation.GetReceiverType(operationContext.Compilation, beforeConversion: true, cancellationToken: operationContext.CancellationToken) is INamedTypeSymbol receiverType
&& receiverType.DerivesFromOrImplementsAnyConstructionOf(immutableCollectionType))
&& receiverType.DerivesFromOrImplementsAnyConstructionOf(immutableCollectionType)
&& ((INamedTypeSymbol)invocation.Type!).TypeArguments[0].Equals(receiverType.TypeArguments[0]))
{
operationContext.ReportDiagnostic(
invocation.CreateDiagnostic(
Expand Down
11 changes: 10 additions & 1 deletion ...s/ImmutableCollections/DoNotCallToImmutableCollectionOnAnImmutableCollectionValueTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,23 @@ static class Extensions
}}
}}

interface IValue
{{
}}

class Value : IValue
{{
}}

class C
{{
public void M(IEnumerable<int> p1, List<int> p2, {collectionName}<int> p3, IEqualityComparer<int> comparer)
public void M(IEnumerable<int> p1, List<int> p2, {collectionName}<int> p3, {collectionName}<Value> p4, IEqualityComparer<int> comparer)
{{
// Allowed
p1.To{collectionName}();
p2.To{collectionName}();
p3.To{collectionName}(comparer); // Potentially modifies the collection
p4.To{collectionName}<IValue>(); // Changes the generic type

Extensions.To{collectionName}(p1);
Extensions.To{collectionName}(p2);
Expand Down
Loading