Make CA1827 fire for 'is' patterns. #7213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7213 +/- ##
========================================
Coverage 96.46% 96.46%
========================================
Files 1427 1427
Lines 341675 341928 +253
Branches 11259 11268 +9
========================================
+ Hits 329581 329846 +265
+ Misses 9245 9232 -13
- Partials 2849 2850 +1 |
mavasani
reviewed
Mar 1, 2024
| @@ -314,6 +321,48 @@ private static bool AnalyzeParentInvocationOperation(IInvocationOperation parent | |||
| return true; | |||
| } | |||
|
|
|||
| private static bool AnalyzeIsPatternOperation(IIsPatternOperation isPatternOperation, out bool shouldNegateIsEmpty) | |||
There was a problem hiding this comment.
Please add a comment about the return values of this method.
mavasani
reviewed
Mar 1, 2024
|
|
||
| if (isPatternOperation.Pattern is INegatedPatternOperation negatedPattern) | ||
| { | ||
| if (negatedPattern.Pattern is IRelationalPatternOperation { OperatorKind: BinaryOperatorKind.GreaterThan, Value: ILiteralOperation { ConstantValue: { HasValue: true, Value: 0 } } } |
There was a problem hiding this comment.
I would suggest adding comments for each of these cases where you have the code corresponding to the condition for easy understanding, probably you can just copy over the corresponding test case code that you have added for each of the conditional branches in this method.
mavasani
reviewed
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7207